From 68fe7c0e567aafeddefb8898ff1f83584b50033d Mon Sep 17 00:00:00 2001
From: Rauno Tuul <raunz@hot.ee>
Date: Wed, 1 Mar 2023 18:43:47 +0200
Subject: [PATCH] Standard user domain records list performance loop
 improvement

---
 powerdnsadmin/routes/domain.py      |  3 ++-
 powerdnsadmin/templates/domain.html | 12 ++++++------
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/powerdnsadmin/routes/domain.py b/powerdnsadmin/routes/domain.py
index 9742760..5fef976 100644
--- a/powerdnsadmin/routes/domain.py
+++ b/powerdnsadmin/routes/domain.py
@@ -133,7 +133,8 @@ def domain(domain_name):
                            editable_records=editable_records,
                            quick_edit=quick_edit,
                            ttl_options=ttl_options,
-                           current_user=current_user)
+                           current_user=current_user,
+                           allow_user_view_history=Setting().get('allow_user_view_history'))
 
 
 @domain_bp.route('/remove', methods=['GET', 'POST'])
diff --git a/powerdnsadmin/templates/domain.html b/powerdnsadmin/templates/domain.html
index 026a89b..9660d38 100755
--- a/powerdnsadmin/templates/domain.html
+++ b/powerdnsadmin/templates/domain.html
@@ -36,7 +36,7 @@
                                         &nbsp;Zone Settings
                                     </button>
                                 {% endif %}
-                                {% if current_user.role.name in ['Administrator', 'Operator'] or SETTING.get('allow_user_view_history') %}
+                                {% if current_user.role.name in ['Administrator', 'Operator'] or allow_user_view_history %}
                                     <button type="button" title="Zone Changelog"
                                             class="btn btn-primary ml-2 mt-2 mb-2 button_changelog" id="{{ domain.name }}">
                                         <i class="fa-solid fa-history" aria-hidden="true"></i>
@@ -79,7 +79,7 @@
                                         <th>Comment</th>
                                         <th>Edit</th>
                                         <th>Delete</th>
-                                        {% if current_user.role.name in ['Administrator', 'Operator'] or SETTING.get('allow_user_view_history') %}
+                                        {% if current_user.role.name in ['Administrator', 'Operator'] or allow_user_view_history %}
                                             <th>Changelog</th>
                                         {% endif %}
                                     {% else %}
@@ -115,7 +115,7 @@
                                                     </button>
                                                 {% endif %}
                                             </td>
-                                            {% if current_user.role.name in ['Administrator', 'Operator'] or SETTING.get('allow_user_view_history') %}
+                                            {% if current_user.role.name in ['Administrator', 'Operator'] or allow_user_view_history %}
                                                 <td>
                                                     <button type="button"
                                                             onclick="show_record_changelog('{{ record.name }}','{{ record.type }}',event)"
@@ -194,7 +194,7 @@
                     // regardless of whatever sorting is done. See orderFixed
                     visible: false,
                     {% if domain.type != 'Slave' %}
-                        {% if current_user.role.name in ['Administrator', 'Operator'] or SETTING.get('allow_user_view_history') %}
+                        {% if current_user.role.name in ['Administrator', 'Operator'] or allow_user_view_history %}
                             targets: [9]
                         {% else %}
                             targets: [8]
@@ -205,7 +205,7 @@
                 }
             ],
             {% if domain.type != 'Slave' %}
-                {% if current_user.role.name in ['Administrator', 'Operator'] or SETTING.get('allow_user_view_history') %}
+                {% if current_user.role.name in ['Administrator', 'Operator'] or allow_user_view_history %}
                     "orderFixed": [[9, 'asc']]
                 {% else %}
                     "orderFixed": [[8, 'asc']]
@@ -314,7 +314,7 @@
 
             // add new row
             var default_type = records_allow_edit[0]
-            {% if current_user.role.name in ['Administrator', 'Operator'] or SETTING.get('allow_user_view_history') %}
+            {% if current_user.role.name in ['Administrator', 'Operator'] or allow_user_view_history %}
                 var nRow = jQuery('#tbl_records').dataTable().fnAddData(['', default_type, 'Active', window.ttl_options[0][0], '', '', '', '', '', '0']);
             {% else %}
                 var nRow = jQuery('#tbl_records').dataTable().fnAddData(['', default_type, 'Active', window.ttl_options[0][0], '', '', '', '', '0']);