From 02700ee7b0b53c7adb5b35f03efc6e4382cacd31 Mon Sep 17 00:00:00 2001 From: Rauno Tuul Date: Wed, 8 Feb 2023 17:03:35 +0200 Subject: [PATCH 1/2] Patch API record update/delete logging to match current logging format --- powerdnsadmin/routes/api.py | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/powerdnsadmin/routes/api.py b/powerdnsadmin/routes/api.py index 3df31e1..0844c32 100644 --- a/powerdnsadmin/routes/api.py +++ b/powerdnsadmin/routes/api.py @@ -1119,14 +1119,16 @@ def api_zone_forward(server_id, zone_id): if Setting().get('enable_api_rr_history'): if request.method in ['POST', 'PATCH']: data = request.get_json(force=True) - for rrset_data in data['rrsets']: - history = History(msg='{0} zone {1} record of {2}'.format( - rrset_data['changetype'].lower(), rrset_data['type'], - rrset_data['name'].rstrip('.')), - detail=json.dumps(data), - created_by=g.apikey.description, - domain_id=Domain().get_id_by_name(zone_id.rstrip('.'))) - history.add() + history = History( + msg='Apply record changes to domain {0}'.format(zone_id.rstrip('.')), + detail = json.dumps({ + 'domain': zone_id.rstrip('.'), + 'add_rrsets': list(filter(lambda r: r['changetype'] == "REPLACE", data['rrsets'])), + 'del_rrsets': list(filter(lambda r: r['changetype'] == "DELETE", data['rrsets'])) + }), + created_by=g.apikey.description, + domain_id=Domain().get_id_by_name(zone_id.rstrip('.'))) + history.add() elif request.method == 'DELETE': history = History(msg='Deleted zone {0}'.format(zone_id.rstrip('.')), detail='', From 187b55e23a2236593866dd4da31fad132372c80d Mon Sep 17 00:00:00 2001 From: Rauno Tuul Date: Wed, 8 Feb 2023 17:03:35 +0200 Subject: [PATCH 2/2] Patch API record update/delete logging to match current logging format --- powerdnsadmin/routes/api.py | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/powerdnsadmin/routes/api.py b/powerdnsadmin/routes/api.py index 3df31e1..0844c32 100644 --- a/powerdnsadmin/routes/api.py +++ b/powerdnsadmin/routes/api.py @@ -1119,14 +1119,16 @@ def api_zone_forward(server_id, zone_id): if Setting().get('enable_api_rr_history'): if request.method in ['POST', 'PATCH']: data = request.get_json(force=True) - for rrset_data in data['rrsets']: - history = History(msg='{0} zone {1} record of {2}'.format( - rrset_data['changetype'].lower(), rrset_data['type'], - rrset_data['name'].rstrip('.')), - detail=json.dumps(data), - created_by=g.apikey.description, - domain_id=Domain().get_id_by_name(zone_id.rstrip('.'))) - history.add() + history = History( + msg='Apply record changes to domain {0}'.format(zone_id.rstrip('.')), + detail = json.dumps({ + 'domain': zone_id.rstrip('.'), + 'add_rrsets': list(filter(lambda r: r['changetype'] == "REPLACE", data['rrsets'])), + 'del_rrsets': list(filter(lambda r: r['changetype'] == "DELETE", data['rrsets'])) + }), + created_by=g.apikey.description, + domain_id=Domain().get_id_by_name(zone_id.rstrip('.'))) + history.add() elif request.method == 'DELETE': history = History(msg='Deleted zone {0}'.format(zone_id.rstrip('.')), detail='',