Merge pull request #407 from ymage/fix-sqlite-alter

Support SQLite ALTER with batch feature during alembic migrate
This commit is contained in:
Khanh Ngo 2018-11-26 10:28:53 +07:00 committed by GitHub
commit 6837b1cead
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 7 deletions

View File

@ -73,6 +73,7 @@ def run_migrations_online():
context.configure(connection=connection,
target_metadata=target_metadata,
process_revision_directives=process_revision_directives,
render_as_batch=config.get_main_option('sqlalchemy.url').startswith('sqlite:'),
**current_app.extensions['migrate'].configure_args)
try:

View File

@ -33,8 +33,9 @@ def update_data():
)
def upgrade():
# change column data type
op.alter_column('setting', 'value', existing_type=sa.String(256), type_=sa.Text())
with op.batch_alter_table('setting') as batch_op:
# change column data type
batch_op.alter_column('value', existing_type=sa.String(256), type_=sa.Text())
# update data for new schema
update_data()
@ -42,5 +43,6 @@ def upgrade():
def downgrade():
# delete added records in previous version
op.execute("DELETE FROM setting WHERE id > 41")
# change column data type
op.alter_column('setting', 'value', existing_type=sa.Text(), type_=sa.String(256))
with op.batch_alter_table('setting') as batch_op:
# change column data type
batch_op.alter_column('value', existing_type=sa.Text(), type_=sa.String(256))

View File

@ -23,8 +23,10 @@ def upgrade():
# written to the DB.
op.execute("DELETE FROM setting")
# drop view column since we don't need it
op.drop_column('setting', 'view')
with op.batch_alter_table('setting') as batch_op:
# drop view column since we don't need it
batch_op.drop_column('view')
def downgrade():
op.add_column('setting', sa.Column('view', sa.String(length=64), nullable=True))
with op.batch_alter_table('setting') as batch_op:
batch_op.add_column(sa.Column('view', sa.String(length=64), nullable=True))