cwinfo/powerdns-admin
4
0
Fork 0
mirror of https://github.com/cwinfo/powerdns-admin.git synced 2025-06-16 04:56:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup

Browse Source 
The `unit/apikey` directory is removed because it does not contain any
tests. Same for `unit/test_decorators.py`.
The `fixture` module is renamed to the special-name `conftest` [0] so
they are available in all tests without the need to import them. With
that in place, I removed all now unneeded or previously already unused
imports from the tests.
Also removed that wierd `sys.path` bit from `unit/zone/test_admin_apikey.py`,
no idea what that was originally intended for.

[0] https://docs.pytest.org/en/6.2.x/fixture.html#conftest-py-sharing-fixtures-across-multiple-files
This commit is contained in:
corubba
2022-06-24 14:19:52 +02:00
committed by Ymage
parent e920bf5009
commit 8d849ee2a1
15 changed files with 8 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/unit/zone/test_admin_apikey.py
View File

@ -2,9 +2,6 @@ import json
import pytest
from unittest.mock import patch
from collections import namedtuple
import sys
import os
sys.path.append(os.getcwd())
import powerdnsadmin
from powerdnsadmin.models.setting import Setting
@ -12,10 +9,8 @@ from powerdnsadmin.models.domain import Domain
from powerdnsadmin.models.api_key import ApiKey
from powerdnsadmin.models.role import Role
from powerdnsadmin.lib.validators import validate_zone
from powerdnsadmin.lib.schema import DomainSchema, ApiKeySchema
from tests.fixtures import client, initial_data, created_zone_data
from tests.fixtures import user_apikey, admin_apikey, zone_data
from tests.fixtures import admin_apikey_data, load_data
from powerdnsadmin.lib.schema import DomainSchema
from tests.conftest import admin_apikey_data, load_data
class TestUnitApiZoneAdminApiKey(object):

4
tests/unit/zone/test_admin_user.py
View File

@ -5,12 +5,10 @@ from collections import namedtuple
import powerdnsadmin
from powerdnsadmin.models.user import User
from powerdnsadmin.models.role import Role
from powerdnsadmin.models.domain import Domain
from powerdnsadmin.lib.validators import validate_zone
from powerdnsadmin.lib.schema import DomainSchema
from tests.fixtures import client, basic_auth_admin_headers
from tests.fixtures import zone_data, created_zone_data, load_data
from tests.conftest import load_data
class TestUnitApiZoneAdminUser(object):

4
tests/unit/zone/test_user.py
View File

@ -5,12 +5,10 @@ from collections import namedtuple
import powerdnsadmin
from powerdnsadmin.models.user import User
from powerdnsadmin.models.role import Role
from powerdnsadmin.models.domain import Domain
from powerdnsadmin.lib.validators import validate_zone
from powerdnsadmin.lib.schema import DomainSchema
from tests.fixtures import client, basic_auth_user_headers
from tests.fixtures import zone_data, created_zone_data, load_data
from tests.conftest import load_data
class TestUnitApiZoneUser(object):

7
tests/unit/zone/test_user_apikey.py
View File

@ -1,7 +1,6 @@
import json
import pytest
from unittest.mock import patch
from base64 import b64encode
from collections import namedtuple
import powerdnsadmin
@ -10,10 +9,8 @@ from powerdnsadmin.models.domain import Domain
from powerdnsadmin.models.api_key import ApiKey
from powerdnsadmin.models.role import Role
from powerdnsadmin.lib.validators import validate_zone
from powerdnsadmin.lib.schema import DomainSchema, ApiKeySchema
from tests.fixtures import client, initial_data, created_zone_data
from tests.fixtures import user_apikey, zone_data
from tests.fixtures import user_apikey_data, load_data
from powerdnsadmin.lib.schema import DomainSchema
from tests.conftest import user_apikey_data, load_data
class TestUnitApiZoneUserApiKey(object):