From c1fae6f3dd9509cae1cd82cd0759df635cf52b36 Mon Sep 17 00:00:00 2001 From: Khanh Ngo Date: Sun, 8 Dec 2019 18:23:36 +0700 Subject: [PATCH] Update README and LGTM fixes --- README.md | 12 ++++-------- powerdnsadmin/__init__.py | 2 +- powerdnsadmin/decorators.py | 2 +- powerdnsadmin/models/__init__.py | 2 +- powerdnsadmin/models/domain.py | 3 +-- 5 files changed, 8 insertions(+), 13 deletions(-) diff --git a/README.md b/README.md index 55fe422..13b37e7 100644 --- a/README.md +++ b/README.md @@ -17,20 +17,16 @@ A PowerDNS web interface with advanced features. - Dashboard and pdns service statistics - DynDNS 2 protocol support - Edit IPv6 PTRs using IPv6 addresses directly (no more editing of literal addresses!) -- limited API for manipulating zones and records +- Limited API for manipulating zones and records ### Running PowerDNS-Admin There are several ways to run PowerDNS-Admin. Following is a simple way to start PowerDNS-Admin using Docker -Step 1: Build docker image +Step 1: Update the configuration -```$ docker-compose build``` +Edit the `docker-compose.yml` file to update the database connection string in `SQLALCHEMY_DATABASE_URI`. Other environment variables are mentioned in the [legal_envvars](https://github.com/ngoduykhanh/PowerDNS-Admin/blob/master/configs/docker_config.py#L5-L37). -Step 2: Change the configuration - -Edit the `docker-compose.yml` file to update the database connection string in `SQLALCHEMY_DATABASE_URI`. - -Step 3: Start docker container +Step 2: Start docker container ```$ docker-compose up``` diff --git a/powerdnsadmin/__init__.py b/powerdnsadmin/__init__.py index 3f7c17a..38c82ff 100755 --- a/powerdnsadmin/__init__.py +++ b/powerdnsadmin/__init__.py @@ -49,7 +49,7 @@ def create_app(config=None): # HSTS if app.config.get('HSTS_ENABLED'): from flask_sslify import SSLify - _sslify = SSLify(app) # lgtm [py/unused-import] + _sslify = SSLify(app) # lgtm [py/unused-local-variable] # Load app's components assets.init_app(app) diff --git a/powerdnsadmin/decorators.py b/powerdnsadmin/decorators.py index 1486928..d34af32 100644 --- a/powerdnsadmin/decorators.py +++ b/powerdnsadmin/decorators.py @@ -131,7 +131,7 @@ def api_basic_auth(f): abort(401) else: user = User.query.filter(User.username == username).first() - current_user = user + current_user = user # lgtm [py/unused-local-variable] except Exception as e: current_app.logger.error('Error: {0}'.format(e)) abort(401) diff --git a/powerdnsadmin/models/__init__.py b/powerdnsadmin/models/__init__.py index 714a198..1562319 100644 --- a/powerdnsadmin/models/__init__.py +++ b/powerdnsadmin/models/__init__.py @@ -20,4 +20,4 @@ from .record_entry import RecordEntry def init_app(app): db.init_app(app) - _migrate = Migrate(app, db) # lgtm [py/unused-import] + _migrate = Migrate(app, db) # lgtm [py/unused-local-variable] diff --git a/powerdnsadmin/models/domain.py b/powerdnsadmin/models/domain.py index 31a2cbe..6ce1741 100644 --- a/powerdnsadmin/models/domain.py +++ b/powerdnsadmin/models/domain.py @@ -287,8 +287,7 @@ class Domain(db.Model): account_id = None # add new domain d = Domain() - d.name = domain['name'].rstrip( - '.') # lgtm [py/modification-of-default-value] + d.name = domain['name'].rstrip('.') # lgtm [py/modification-of-default-value] d.master = str(domain['masters']) d.type = domain['kind'] d.serial = domain['serial']