Commit Graph

34 Commits

Author SHA1 Message Date
204c996c81 Merge pull request #1221 from corubba/bugfix/changelog-hyphen
Fix rrset changelog for names with hyphen
2022-07-01 15:52:44 +03:00
5036619a67 Allow new domains to be absolute
Allow the new domain name to be input absolute (with a dot at the end).
To keep the rest of the logic working as-is, remove it fairly early in
the function.

Would have loved to use `str.removesuffix()` but that's python v3.9+.
2022-06-23 22:31:00 +02:00
9890ddfa64 Fix rrset changelog for names with hyphen
When clicking the changelog button for a record with the name
`foo-bar.example.org`, the url you get redirected to is
`/domain/example.org/changelog/foo-bar.example.org.-A`. Because of the
non-greedy behaviour of the path converter, the last part gets split at
the *first* hyphen, so the example above gets wrongly dissected into
`record_name=foo` and `record_type=bar.example.org.-A`. This results
for obvious reasons in an empty changelog.

As described in rfc5395 [0], types have to be alphanumerical, so its
converter is changed from path to string.

The hyphen is one of the few characters recommended by rfc1035 [1],
so it is a bad choice as separator. The separator is instead changed to
a slash.
Granted, this does not entirely solve the issue but at least makes it a
lot less likely to happen. Plus, a lot more and other things break in
pda with slashes in names.

[0] https://datatracker.ietf.org/doc/html/rfc5395#section-3.1
[1] https://datatracker.ietf.org/doc/html/rfc1035#section-2.3.1
2022-06-19 12:16:40 +02:00
1926b862b8 feat: Option to forbid the creation of domain if it exists as a record (#1127)
When enabled, forbids the creation of a domain if it exists as a record in one of its parent domains (administrators and operators are not limited though).
2022-06-17 17:50:51 +02:00
2a75013de4 Merge pull request #1163 from AdvanticGmbH/idna_decode
fix: use idna module to support extended character set
2022-06-17 15:47:55 +02:00
0dfcdb6c3e Fix rrest typo in history detail
There is a misspelling of rrset throughout the history logic, which also
effects the json payload in the database. Code-wise this is a simple
search-and-replace, and the migration will fix the payloads.
2022-05-19 00:53:35 +02:00
64f7968af9 fix: Use json.dumps instead of str 2022-05-06 17:04:39 +02:00
26c60f175d Remove unnecessary call to str()
* json.dumps() already returns a str
2022-04-26 09:11:05 +02:00
44c9aff5db Use json.dumps for every detail in history
This works much better instead of just writing a str to the db and
expect it to be loaded just fine from json.loads
2022-04-25 10:43:46 +02:00
191e919626 Allow IDNA in SOA
* Previously having characters like "ü" in the SOA wouldnt allow to push
updates to the domain
* Also use the new method to_idna to support characters like "ß"
2022-04-25 10:19:40 +02:00
e21f53085d added DNSSEC enabling/disabling to history logs 2022-02-17 17:40:48 +02:00
caa48b7fe5 Merge branch 'quotes-fix'
Conflicts:
	powerdnsadmin/routes/admin.py
2021-12-03 14:17:39 +00:00
1332c8d29d History Tab Overhaul & Domain Record Modifications Changelog (#1042)
Co-authored-by: Konstantinos Kouris <85997752+konkourgr@users.noreply.github.com>
Co-authored-by: vmarkop <billy.mark.b.m.10@gmail.com>
Co-authored-by: KostasMparmparousis <mparmparousis.kostas@gmail.com>
Co-authored-by: dimpapac <demispapa@gmail.com>
2021-11-30 11:02:37 +02:00
bf83662108 allow users to remove domain (#952) 2021-10-30 21:21:45 +02:00
993e02b635 limit user to only create domains for the accounts he belongs to (#970) 2021-08-05 19:42:58 +02:00
98db953820 Allow user role to view history (#890) 2021-03-27 19:33:11 +01:00
46993e08c0 Add punycode (IDN) support (#879) 2021-03-16 19:37:05 +01:00
3034630bc0 Merge pull request #761 from ngoduykhanh/record_rollback
Fix #752 - Rollback the removed record if apply operation failed
2020-10-11 13:01:26 +02:00
b5fc9045f2 Merge pull request #766 from frei-style/sort_accounts
Sort accounts by name on 'New Domain' and domain 'Admin'
2020-10-10 14:18:02 +02:00
cf62658e19 do not fail with wildcard PTRs 2020-09-10 01:18:07 +07:00
9946f72a85 Order accounts by name on 'New Domain' and domain admin 2020-06-28 01:59:12 +02:00
1f4580a27a Log failed domain apply operation 2020-06-20 09:51:30 +07:00
3476c8a9ec SJS Sort rrset members by content before comparison to ensure correct compare. Also default comment to blank entry rather than missing entry, to allow sorting to work correctly. 2020-05-20 16:21:28 +12:00
33eff6313f Fix loading zone with Slave type 2020-05-02 09:41:01 +07:00
93cd64ac75 Fix #613. Create domain from template with SOA record enabled 2019-12-19 21:43:53 +07:00
7205b4a01b User session improvement
- Add session handler on other blueprint's before request
- Adjustment in using jTimeout to close warning popup on
other tabs when we extend the session
2019-12-18 15:25:20 +07:00
3196297f57 Fix domain template. Drop PDNS 3.x support 2019-12-16 14:23:17 +07:00
5ac58d5503 Re-add pretty_ipv6_ptr. Bug fixes 2019-12-14 23:13:55 +07:00
14658d797e Adjustment in domain's record applying 2019-12-14 14:47:21 +07:00
1d973d1614 Allow update zone kind the domain setting page 2019-12-11 16:02:36 +07:00
bca3c45e37 Add record comment 2019-12-09 17:50:48 +07:00
6af94df00a LGTM fixes. Remove unused import and variables 2019-12-07 20:20:40 +07:00
840e2a4750 Update docker stuff and bug fixes 2019-12-04 11:50:46 +07:00
8ea00b9484 Refactoring the code
- Use Flask blueprint
- Split model and views into smaller parts
- Bug fixes
- API adjustment
2019-12-02 10:32:03 +07:00