mirror of
https://github.com/cwinfo/powerdns-admin.git
synced 2024-12-27 05:25:40 +00:00
9890ddfa64
When clicking the changelog button for a record with the name `foo-bar.example.org`, the url you get redirected to is `/domain/example.org/changelog/foo-bar.example.org.-A`. Because of the non-greedy behaviour of the path converter, the last part gets split at the *first* hyphen, so the example above gets wrongly dissected into `record_name=foo` and `record_type=bar.example.org.-A`. This results for obvious reasons in an empty changelog. As described in rfc5395 [0], types have to be alphanumerical, so its converter is changed from path to string. The hyphen is one of the few characters recommended by rfc1035 [1], so it is a bad choice as separator. The separator is instead changed to a slash. Granted, this does not entirely solve the issue but at least makes it a lot less likely to happen. Plus, a lot more and other things break in pda with slashes in names. [0] https://datatracker.ietf.org/doc/html/rfc5395#section-3.1 [1] https://datatracker.ietf.org/doc/html/rfc1035#section-2.3.1 |
||
|---|---|---|
| .. | ||
| emails | ||
| errors | ||
| admin_edit_account.html | ||
| admin_edit_key.html | ||
| admin_edit_user.html | ||
| admin_global_search.html | ||
| admin_history_table.html | ||
| admin_history.html | ||
| admin_manage_account.html | ||
| admin_manage_keys.html | ||
| admin_manage_user.html | ||
| admin_pdns_stats.html | ||
| admin_setting_authentication.html | ||
| admin_setting_basic.html | ||
| admin_setting_pdns.html | ||
| admin_setting_records.html | ||
| applied_change_macro.html | ||
| base.html | ||
| dashboard_domain.html | ||
| dashboard.html | ||
| domain_add.html | ||
| domain_changelog.html | ||
| domain_remove.html | ||
| domain_setting.html | ||
| domain.html | ||
| dyndns.html | ||
| email_confirmation.html | ||
| login.html | ||
| maintenance.html | ||
| register_otp.html | ||
| register.html | ||
| resend_confirmation_email.html | ||
| template_add.html | ||
| template_edit.html | ||
| template.html | ||
| user_profile.html | ||