mirror of
https://github.com/cwinfo/powerdns-admin.git
synced 2024-11-08 14:40:27 +00:00
9890ddfa64
When clicking the changelog button for a record with the name `foo-bar.example.org`, the url you get redirected to is `/domain/example.org/changelog/foo-bar.example.org.-A`. Because of the non-greedy behaviour of the path converter, the last part gets split at the *first* hyphen, so the example above gets wrongly dissected into `record_name=foo` and `record_type=bar.example.org.-A`. This results for obvious reasons in an empty changelog. As described in rfc5395 [0], types have to be alphanumerical, so its converter is changed from path to string. The hyphen is one of the few characters recommended by rfc1035 [1], so it is a bad choice as separator. The separator is instead changed to a slash. Granted, this does not entirely solve the issue but at least makes it a lot less likely to happen. Plus, a lot more and other things break in pda with slashes in names. [0] https://datatracker.ietf.org/doc/html/rfc5395#section-3.1 [1] https://datatracker.ietf.org/doc/html/rfc1035#section-2.3.1 |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| admin.py | ||
| api.py | ||
| base.py | ||
| dashboard.py | ||
| domain.py | ||
| index.py | ||
| user.py | ||