From f599a1a2c159f9feb71aefb140555610b6e37e98 Mon Sep 17 00:00:00 2001 From: Arceliar Date: Thu, 21 Jun 2018 10:32:16 -0500 Subject: [PATCH 1/3] start the pprof based on an env variable in debug builds, otherwise remove the flag/release.go stuff --- src/yggdrasil/debug.go | 14 ++++++++++++++ src/yggdrasil/release.go | 14 -------------- yggdrasil.go | 7 ------- 3 files changed, 14 insertions(+), 21 deletions(-) delete mode 100644 src/yggdrasil/release.go diff --git a/src/yggdrasil/debug.go b/src/yggdrasil/debug.go index 2cf9040..f95bfa3 100644 --- a/src/yggdrasil/debug.go +++ b/src/yggdrasil/debug.go @@ -20,6 +20,20 @@ import "regexp" import _ "net/http/pprof" import "net/http" import "runtime" +import "os" + +// Start the profiler in debug builds, if the required environment variable is set. +func init() { + envVarName := "PPROFLISTEN" + hostPort := os.Getenv(envVarName) + switch { + case hostPort == "": + fmt.Printf("DEBUG: %s not set, profiler not started.\n", envVarName) + default: + fmt.Printf("DEBUG: Starting pprof on %s\n", hostPort) + go func() { fmt.Println(http.ListenAndServe(hostPort, nil)) }() + } +} // Starts the function profiler. This is only supported when built with // '-tags build'. diff --git a/src/yggdrasil/release.go b/src/yggdrasil/release.go deleted file mode 100644 index 3b13690..0000000 --- a/src/yggdrasil/release.go +++ /dev/null @@ -1,14 +0,0 @@ -// +build !debug - -package yggdrasil - -import ( - "errors" - "log" -) - -// Starts the function profiler. This is only supported when built with -// '-tags build'. -func StartProfiler(_ *log.Logger) error { - return errors.New("Release builds do not support -pprof, build using '-tags debug'") -} diff --git a/yggdrasil.go b/yggdrasil.go index d29c65b..20b4aa0 100644 --- a/yggdrasil.go +++ b/yggdrasil.go @@ -82,7 +82,6 @@ func doGenconf() string { // The main function is responsible for configuring and starting Yggdrasil. func main() { // Configure the command line parameters. - pprof := flag.Bool("pprof", false, "Run pprof, see http://localhost:6060/debug/pprof/") genconf := flag.Bool("genconf", false, "print a new config to stdout") useconf := flag.Bool("useconf", false, "read config from stdin") useconffile := flag.String("useconffile", "", "read config from specified file path") @@ -203,12 +202,6 @@ func main() { } // Create a new logger that logs output to stdout. logger := log.New(os.Stdout, "", log.Flags()) - // If the -pprof flag was provided then start the pprof service on port 6060. - if *pprof { - if err := yggdrasil.StartProfiler(logger); err != nil { - logger.Println(err) - } - } // Setup the Yggdrasil node itself. The node{} type includes a Core, so we // don't need to create this manually. n := node{} From 19014a198eb1a94f884a3a7086dde85f35e9f596 Mon Sep 17 00:00:00 2001 From: Arceliar Date: Thu, 21 Jun 2018 10:38:31 -0500 Subject: [PATCH 2/3] randomize the delay after tcp disconnects, to prevent synchronization issues --- src/yggdrasil/tcp.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/yggdrasil/tcp.go b/src/yggdrasil/tcp.go index 5408b6b..1e62f46 100644 --- a/src/yggdrasil/tcp.go +++ b/src/yggdrasil/tcp.go @@ -17,6 +17,7 @@ package yggdrasil import ( "errors" "fmt" + "math/rand" "net" "sync" "sync/atomic" @@ -112,6 +113,7 @@ func (iface *tcpInterface) call(saddr string, socksaddr *string) { defer func() { // Block new calls for a little while, to mitigate livelock scenarios time.Sleep(tcp_timeout) + time.Sleep(time.Duration(rand.Intn(1000)) * time.Millisecond) iface.mutex.Lock() delete(iface.calls, saddr) iface.mutex.Unlock() From 254be42614a656b53c4aa3ce485d06e4cdc52fd4 Mon Sep 17 00:00:00 2001 From: Arceliar Date: Thu, 21 Jun 2018 10:39:43 -0500 Subject: [PATCH 3/3] gofmt --- contrib/config/yggdrasilconf.go | 86 ++++++++++++++++----------------- src/yggdrasil/tcp.go | 4 +- 2 files changed, 45 insertions(+), 45 deletions(-) diff --git a/contrib/config/yggdrasilconf.go b/contrib/config/yggdrasilconf.go index 12048c3..bc6e132 100644 --- a/contrib/config/yggdrasilconf.go +++ b/contrib/config/yggdrasilconf.go @@ -9,13 +9,13 @@ the command line arguments, and then spits out an updated file. import ( "bytes" "encoding/json" - "flag" + "flag" "fmt" "io/ioutil" - "strconv" + "strconv" - "golang.org/x/text/encoding/unicode" "github.com/neilalexander/hjson-go" + "golang.org/x/text/encoding/unicode" "yggdrasil/config" ) @@ -23,8 +23,8 @@ import ( type nodeConfig = config.NodeConfig func main() { - useconffile := flag.String("useconffile", "/etc/yggdrasil.conf", "update config at specified file path") - flag.Parse() + useconffile := flag.String("useconffile", "/etc/yggdrasil.conf", "update config at specified file path") + flag.Parse() cfg := nodeConfig{} var config []byte var err error @@ -50,44 +50,44 @@ func main() { panic(err) } json.Unmarshal(confJson, &cfg) - switch flag.Arg(0) { - case "setMTU": - cfg.IfMTU, err = strconv.Atoi(flag.Arg(1)) - if err != nil { - cfg.IfMTU = 1280 - } - if mtu, _ := strconv.Atoi(flag.Arg(1)); mtu < 1280 { - cfg.IfMTU = 1280 - } - case "setIfName": - cfg.IfName = flag.Arg(1) - case "setListen": - cfg.Listen = flag.Arg(1) - case "setAdminListen": - cfg.AdminListen = flag.Arg(1) - case "setIfTapMode": - if flag.Arg(1) == "true" { - cfg.IfTAPMode = true - } else { - cfg.IfTAPMode = false - } - case "addPeer": - found := false - for _, v := range cfg.Peers { - if v == flag.Arg(1) { - found = true - } - } - if !found { - cfg.Peers = append(cfg.Peers, flag.Arg(1)) - } - case "removePeer": - for k, v := range cfg.Peers { - if v == flag.Arg(1) { - cfg.Peers = append(cfg.Peers[:k], cfg.Peers[k+1:]...) - } - } - } + switch flag.Arg(0) { + case "setMTU": + cfg.IfMTU, err = strconv.Atoi(flag.Arg(1)) + if err != nil { + cfg.IfMTU = 1280 + } + if mtu, _ := strconv.Atoi(flag.Arg(1)); mtu < 1280 { + cfg.IfMTU = 1280 + } + case "setIfName": + cfg.IfName = flag.Arg(1) + case "setListen": + cfg.Listen = flag.Arg(1) + case "setAdminListen": + cfg.AdminListen = flag.Arg(1) + case "setIfTapMode": + if flag.Arg(1) == "true" { + cfg.IfTAPMode = true + } else { + cfg.IfTAPMode = false + } + case "addPeer": + found := false + for _, v := range cfg.Peers { + if v == flag.Arg(1) { + found = true + } + } + if !found { + cfg.Peers = append(cfg.Peers, flag.Arg(1)) + } + case "removePeer": + for k, v := range cfg.Peers { + if v == flag.Arg(1) { + cfg.Peers = append(cfg.Peers[:k], cfg.Peers[k+1:]...) + } + } + } bs, err := hjson.Marshal(cfg) if err != nil { panic(err) diff --git a/src/yggdrasil/tcp.go b/src/yggdrasil/tcp.go index 1e62f46..db57b56 100644 --- a/src/yggdrasil/tcp.go +++ b/src/yggdrasil/tcp.go @@ -17,7 +17,7 @@ package yggdrasil import ( "errors" "fmt" - "math/rand" + "math/rand" "net" "sync" "sync/atomic" @@ -113,7 +113,7 @@ func (iface *tcpInterface) call(saddr string, socksaddr *string) { defer func() { // Block new calls for a little while, to mitigate livelock scenarios time.Sleep(tcp_timeout) - time.Sleep(time.Duration(rand.Intn(1000)) * time.Millisecond) + time.Sleep(time.Duration(rand.Intn(1000)) * time.Millisecond) iface.mutex.Lock() delete(iface.calls, saddr) iface.mutex.Unlock()