mirror of
https://github.com/cwinfo/matterbridge.git
synced 2024-12-24 18:25:40 +00:00
For an unknown reason we get duplicate messages (from the same channel) using the realtime API when we have > 1 channel subscribed on. Solution for now is caching the message ID in a LRU cache and ignoring the duplicates. This should be reviewed when we have actual editing support from the realtime API
This commit is contained in:
parent
f57370f33a
commit
53aa076555
@ -40,6 +40,11 @@ func (b *Brocketchat) handleRocketHook(messages chan *config.Message) {
|
||||
|
||||
func (b *Brocketchat) handleRocketClient(messages chan *config.Message) {
|
||||
for message := range b.messageChan {
|
||||
// skip messages with same ID, apparently messages get duplicated for an unknown reason
|
||||
if _, ok := b.cache.Get(message.ID); ok {
|
||||
continue
|
||||
}
|
||||
b.cache.Add(message.ID, true)
|
||||
b.Log.Debugf("message %#v", message)
|
||||
m := message
|
||||
if b.skipMessage(&m) {
|
||||
|
@ -9,16 +9,18 @@ import (
|
||||
"github.com/42wim/matterbridge/bridge/helper"
|
||||
"github.com/42wim/matterbridge/hook/rockethook"
|
||||
"github.com/42wim/matterbridge/matterhook"
|
||||
lru "github.com/hashicorp/golang-lru"
|
||||
"github.com/matterbridge/Rocket.Chat.Go.SDK/models"
|
||||
"github.com/matterbridge/Rocket.Chat.Go.SDK/realtime"
|
||||
"github.com/matterbridge/Rocket.Chat.Go.SDK/rest"
|
||||
)
|
||||
|
||||
type Brocketchat struct {
|
||||
mh *matterhook.Client
|
||||
rh *rockethook.Client
|
||||
c *realtime.Client
|
||||
r *rest.Client
|
||||
mh *matterhook.Client
|
||||
rh *rockethook.Client
|
||||
c *realtime.Client
|
||||
r *rest.Client
|
||||
cache *lru.Cache
|
||||
*bridge.Config
|
||||
messageChan chan models.Message
|
||||
channelMap map[string]string
|
||||
@ -27,9 +29,16 @@ type Brocketchat struct {
|
||||
}
|
||||
|
||||
func New(cfg *bridge.Config) bridge.Bridger {
|
||||
b := &Brocketchat{Config: cfg}
|
||||
b.messageChan = make(chan models.Message)
|
||||
b.channelMap = make(map[string]string)
|
||||
newCache, err := lru.New(100)
|
||||
if err != nil {
|
||||
cfg.Log.Fatalf("Could not create LRU cache for rocketchat bridge: %v", err)
|
||||
}
|
||||
b := &Brocketchat{
|
||||
Config: cfg,
|
||||
messageChan: make(chan models.Message),
|
||||
channelMap: make(map[string]string),
|
||||
cache: newCache,
|
||||
}
|
||||
b.Log.Debugf("enabling rocketchat")
|
||||
return b
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user