Merge pull request #140 from Arceliar/misc

Misc cleanup

contrib/config/yggdrasilconf.go

@@ -9,13 +9,13 @@ the command line arguments, and then spits out an updated file.
 import (
 	"bytes"
 	"encoding/json"
-  "flag"
+	"flag"
 	"fmt"
 	"io/ioutil"
-  "strconv"
+	"strconv"
 
-	"golang.org/x/text/encoding/unicode"
 	"github.com/neilalexander/hjson-go"
+	"golang.org/x/text/encoding/unicode"
 
 	"yggdrasil/config"
 )
@@ -23,8 +23,8 @@ import (
 type nodeConfig = config.NodeConfig
 
 func main() {
-  useconffile := flag.String("useconffile", "/etc/yggdrasil.conf", "update config at specified file path")
+	useconffile := flag.String("useconffile", "/etc/yggdrasil.conf", "update config at specified file path")
-  flag.Parse()
+	flag.Parse()
 	cfg := nodeConfig{}
 	var config []byte
 	var err error
@@ -50,44 +50,44 @@ func main() {
 		panic(err)
 	}
 	json.Unmarshal(confJson, &cfg)
-  switch flag.Arg(0) {
+	switch flag.Arg(0) {
-  case "setMTU":
+	case "setMTU":
-    cfg.IfMTU, err = strconv.Atoi(flag.Arg(1))
+		cfg.IfMTU, err = strconv.Atoi(flag.Arg(1))
-    if err != nil {
+		if err != nil {
-      cfg.IfMTU = 1280
+			cfg.IfMTU = 1280
-    }
+		}
-    if mtu, _ := strconv.Atoi(flag.Arg(1)); mtu < 1280 {
+		if mtu, _ := strconv.Atoi(flag.Arg(1)); mtu < 1280 {
-      cfg.IfMTU = 1280
+			cfg.IfMTU = 1280
-    }
+		}
-  case "setIfName":
+	case "setIfName":
-    cfg.IfName = flag.Arg(1)
+		cfg.IfName = flag.Arg(1)
-  case "setListen":
+	case "setListen":
-    cfg.Listen = flag.Arg(1)
+		cfg.Listen = flag.Arg(1)
-  case "setAdminListen":
+	case "setAdminListen":
-    cfg.AdminListen = flag.Arg(1)
+		cfg.AdminListen = flag.Arg(1)
-  case "setIfTapMode":
+	case "setIfTapMode":
-    if flag.Arg(1) == "true" {
+		if flag.Arg(1) == "true" {
-      cfg.IfTAPMode = true
+			cfg.IfTAPMode = true
-    } else {
+		} else {
-      cfg.IfTAPMode = false
+			cfg.IfTAPMode = false
-    }
+		}
-  case "addPeer":
+	case "addPeer":
-    found := false
+		found := false
-    for _, v := range cfg.Peers {
+		for _, v := range cfg.Peers {
-      if v == flag.Arg(1) {
+			if v == flag.Arg(1) {
-        found = true
+				found = true
-      }
+			}
-    }
+		}
-    if !found {
+		if !found {
-      cfg.Peers = append(cfg.Peers, flag.Arg(1))
+			cfg.Peers = append(cfg.Peers, flag.Arg(1))
-    }
+		}
-  case "removePeer":
+	case "removePeer":
-    for k, v := range cfg.Peers {
+		for k, v := range cfg.Peers {
-      if v == flag.Arg(1) {
+			if v == flag.Arg(1) {
-        cfg.Peers = append(cfg.Peers[:k], cfg.Peers[k+1:]...)
+				cfg.Peers = append(cfg.Peers[:k], cfg.Peers[k+1:]...)
-      }
+			}
-    }
+		}
-  }
+	}
 	bs, err := hjson.Marshal(cfg)
 	if err != nil {
 		panic(err)

src/yggdrasil/debug.go

@@ -20,6 +20,20 @@ import "regexp"
 import _ "net/http/pprof"
 import "net/http"
 import "runtime"
+import "os"
+
+// Start the profiler in debug builds, if the required environment variable is set.
+func init() {
+	envVarName := "PPROFLISTEN"
+	hostPort := os.Getenv(envVarName)
+	switch {
+	case hostPort == "":
+		fmt.Printf("DEBUG: %s not set, profiler not started.\n", envVarName)
+	default:
+		fmt.Printf("DEBUG: Starting pprof on %s\n", hostPort)
+		go func() { fmt.Println(http.ListenAndServe(hostPort, nil)) }()
+	}
+}
 
 // Starts the function profiler. This is only supported when built with
 // '-tags build'.

src/yggdrasil/release.go

@@ -1,14 +0,0 @@
-// +build !debug
-
-package yggdrasil
-
-import (
-	"errors"
-	"log"
-)
-
-// Starts the function profiler. This is only supported when built with
-// '-tags build'.
-func StartProfiler(_ *log.Logger) error {
-	return errors.New("Release builds do not support -pprof, build using '-tags debug'")
-}

src/yggdrasil/tcp.go

@@ -17,6 +17,7 @@ package yggdrasil
 import (
 	"errors"
 	"fmt"
+	"math/rand"
 	"net"
 	"sync"
 	"sync/atomic"
@@ -112,6 +113,7 @@ func (iface *tcpInterface) call(saddr string, socksaddr *string) {
 			defer func() {
 				// Block new calls for a little while, to mitigate livelock scenarios
 				time.Sleep(tcp_timeout)
+				time.Sleep(time.Duration(rand.Intn(1000)) * time.Millisecond)
 				iface.mutex.Lock()
 				delete(iface.calls, saddr)
 				iface.mutex.Unlock()

yggdrasil.go

@@ -82,7 +82,6 @@ func doGenconf() string {
 // The main function is responsible for configuring and starting Yggdrasil.
 func main() {
 	// Configure the command line parameters.
-	pprof := flag.Bool("pprof", false, "Run pprof, see http://localhost:6060/debug/pprof/")
 	genconf := flag.Bool("genconf", false, "print a new config to stdout")
 	useconf := flag.Bool("useconf", false, "read config from stdin")
 	useconffile := flag.String("useconffile", "", "read config from specified file path")
@@ -203,12 +202,6 @@ func main() {
 	}
 	// Create a new logger that logs output to stdout.
 	logger := log.New(os.Stdout, "", log.Flags())
-	// If the -pprof flag was provided then start the pprof service on port 6060.
-	if *pprof {
-		if err := yggdrasil.StartProfiler(logger); err != nil {
-			logger.Println(err)
-		}
-	}
 	// Setup the Yggdrasil node itself. The node{} type includes a Core, so we
 	// don't need to create this manually.
 	n := node{}